Skip to content

OSX: add BMFF support for macports exiv2 0.27.4 #9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

OSX: add BMFF support for macports exiv2 0.27.4 #9411

wants to merge 2 commits into from

Conversation

MStraeten
Copy link
Collaborator

by default exiv2 0.27.4 is configured without BMFF support.
in addition to #8751 macports portfile needs to be patched to add BMFF support to the configuration

Be aware: if BMFF support is enabled it's possible to import cr3 files even these can't be processed until cr3 support arrives in rawspeed.

MStraeten added 2 commits July 4, 2021 21:01
macports exiv2 0.27.4 doesn't contain BMFF support by default so it needs be added during configuration
macports exiv2 0.27.4 doesn't contain BMFF support by default so it needs be added during configuration
@parafin
Copy link
Member

parafin commented Jul 4, 2021

Since rawspeed doesn’t yet have CR3 support, I see no rush on adding this patch to build instructions. Instead I propose to try to upstream it to macports. BTW I built the release package with the latest osm-gps-map release, I’ve created an update issue for macports, but haven’t included it to build instructions assuming that version will be bumped soon enough in macports. IMHO we should try to upstream as much as possible to macports. They are not very willing to accept fixes for making deployment target option working, so these will stay in dt build instructions, but anything else should go to macports bug tracker IMHO.

@MStraeten
Copy link
Collaborator Author

i'm fine with that. At least with exiv2 1.0 BMFF will be default.
so i'll close this

@MStraeten MStraeten closed this Jul 4, 2021
@MStraeten
Copy link
Collaborator Author

now that cr3 is provides and macports exiv2 is yet 0.27.4 this change is needed.

@parafin
Copy link
Member

parafin commented Nov 16, 2021

I will integrate it as soon as I test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants