Add catcherror callback for sendData
#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Apr 4, 2023
DanTup
approved these changes
Apr 4, 2023
| ); | ||
| ) | ||
| .catchError((error) { | ||
| return Future<http.Response>.value(http.Response(error.toString(), 500)); |
There was a problem hiding this comment.
Is it worth noting this behaviour in the Dartdoc, just so it's clear to callers that they don't need to handle it, and a response with a 500 code isn't necessarily from the server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by Danny, the package will cause which ever tool is using it to crash if the client fails to send an event.
This PR adds error handling so that each tool using this package won't crash the tool using it in the case of a http client error (ie. wifi connection drops, client connection was closed before events were sent, etc.)
Google analytics will always return a
2xxstatus code for events they have received, as such, if a tool using this package would like to confirm that the event sent, they can check the response fromanalytics.sendData(...)if it is2xx. However, if the package failed to send the data, this PR will return a status code of500indicating that something is wrong with the http client.