feat(gcp-detector): add Cloud Run support with faas.* #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, and faas.instance Signed-off-by: Kasper Borg Nissen <[email protected]>
Signed-off-by: Kasper Borg Nissen <[email protected]>
kaspernissen
force-pushed
the
feat/gcp-detector-cloud-run-support
branch
from
38cf6c5 to
7c14194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The GCP resource detector for Node.js did not previously support Cloud Run–specific resource attributes, although these are supported in other SDKs (e.g. Go, Java). This PR adds support for setting the
faas.*attributes when running in a Cloud Run environment.Short description of the changes
faas.namefromK_SERVICEenvironment variablefaas.versionfromK_REVISIONenvironment variablefaas.instancefrom GCP metadata server (/instance/id)