Skip to content

Remove deprecated PubSub #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

Remove deprecated PubSub #9039

merged 4 commits into from
Apr 15, 2025

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Apr 8, 2025

We flagged this as deprecated ~9 months ago and one of the unit tests is flaky so I suggest to pull the plug

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  +    13      27 suites  +13   11h 32m 46s ⏱️ + 7h 10m 26s
 4 100 tests  -      6   3 984 ✅  -      8    112 💤  -     1  4 ❌ +3 
51 400 runs  +28 163  49 087 ✅ +27 049  2 309 💤 +1 111  4 ❌ +3 

For more details on these failures, see this check.

Results for commit b82a574. ± Comparison against base commit 43e38b5.

This pull request removes 6 tests.
distributed.tests.test_pubsub ‑ test_basic
distributed.tests.test_pubsub ‑ test_client
distributed.tests.test_pubsub ‑ test_client_worker
distributed.tests.test_pubsub ‑ test_repr
distributed.tests.test_pubsub ‑ test_speed
distributed.tests.test_pubsub ‑ test_timeouts

♻️ This comment has been updated with latest results.

@hendrikmakait
Copy link
Member

It looks like CI isn't happy and the extension is still imported in the client.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fjetter. It'd be good to see if these are referenced over in dask/dask. I think they're probably in the docs at a minimum.

@fjetter fjetter merged commit 16aa189 into dask:main Apr 15, 2025
27 of 31 checks passed
@fjetter
Copy link
Member Author

fjetter commented Apr 15, 2025

I couldn't find any references to this in the dask/dask repo

@fjetter fjetter deleted the remove_pubsub branch April 15, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants