Skip to content

Return a default value if address resolution fails #9051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

penguinpee
Copy link
Contributor

If getaddrinfo() fails for whatever reason, return the default
loopback address instead. This allows running tests on systems
that are otherwise not connected to a network.

If getaddrinfo() fails for whatever reason, return the default
loopback address instead. This allows running tests on systems
that are otherwise not connected to a network.
@penguinpee penguinpee requested a review from fjetter as a code owner April 18, 2025 07:49
@penguinpee
Copy link
Contributor Author

Fedora's build environment has always been restricted with regards to network. Recently, I noticed address resolution no longer working. That impacted the entire test suite, while the loopback adapter remains available.

It turns out this builds on the work of a fellow Fedorian (#8712). The warning message should allow for dask's tests to pass (currently testing), which already has "ignore:Couldn't detect a suitable IP address:RuntimeWarning:distributed", in pytest.filterwarnings.

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   11h 3m 15s ⏱️ - 3m 59s
 4 101 tests ±0   3 987 ✅ +2    112 💤 ±0  2 ❌  - 2 
51 413 runs  ±0  49 112 ✅ +3  2 297 💤  - 1  4 ❌  - 2 

For more details on these failures, see this check.

Results for commit a9f2f39. ± Comparison against base commit 3f17ddb.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. The CI failures appear to be unrelated.

@jacobtomlinson jacobtomlinson merged commit 224ae88 into dask:main Apr 22, 2025
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants