Bug fix: The HasNext() function for Go driver arrow record iterator returning EOF for empty result set. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturning EOF for empty resultset. Essentially, the HasNext() logic was assuming there were records in the result set in the case that the original return from executing the statement didn't specify, or if there were direct results. Updated arrowRecordIterator.HasNext() to check state of underlying iterators. This handles the case of direct results that contain no records. Updated resultPageIterator.HasNext() to try fetching a result page if necessary to determine if there are more records. Added tests for empty result sets with direct results enabled and disabled. Signed-off-by: Raymond Cypher <[email protected]>
rcypher-databricks
requested review from
susodapop,
yunbodeng-db,
andrefurlan-db and
jadewang-db
as code owners
andrefurlan-db
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: The HasNext() function for Go driver arrow record iterator returning EOF for empty result set.
Essentially, the HasNext() logic was assuming there were records in the result set in the case that the original return from executing the statement didn't specify, or if there were no direct results.
Updated arrowRecordIterator.HasNext() to check state of underlying iterators. This handles the case of direct results that contain no records.
Updated resultPageIterator.HasNext() to try fetching a result page if necessary to determine if there are more records.
Added tests for empty result sets with direct results enabled and disabled.
Internal ticket: ES-975398