CNDB-11762: Remove StorageAttachedIndexQueryPlan#postProcessor

[adelapena]

StorageAttachedIndexQueryPlan#postProcessor seems redundant because coordinator-side sorting+triming of ANN query results is already done in SelectStatement. If that's the case, we should remove it.

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits

[jbellis]

it looks like the whole postReconciliationProcessing -> postProcessor chain can be removed since the only remaining postProcessor is a no-op?

[adelapena]

it looks like the whole postReconciliationProcessing -> postProcessor chain can be removed since the only remaining postProcessor is a no-op?

Probably yes, since I think we don't have 3rd party 2i implementations using it for sorting.

I suspect that in the long term sorting will be better placed at the same level as postReconciliationProcessing, in the org.apache.cassandra.db package, rather than embedded in CQL. But for now, we can remove it and keep using the CQL version of sorting, which seems more evolved (and faster!).

[sonarqubecloud]

Quality Gate failed

Failed conditions
64.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1422 rejected by Butler

---

4 new test failure(s) in 7 builds
See build details here

---

Found 4 new test failures

Test	Explanation	Branch history	Upstream history
...Test.shadowedPrimaryKeysRequireDeeperSearch[dc]	flaky	🔵🔴🔵🔵	🔵🔵🔵🔵🔵🔵🔵
...t,varint>,wide=false,scenario=POST_BUILD_QUERY]	regression	🔴🔵🔵🔵	🔵🔵🔵🔵🔵🔵🔵
...set>,wide=true,scenario=MEMTABLE_QUERY]	regression	🔴🔵🔵🔵	🔵🔵🔵🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS...	flaky	🔵🔴🔵🔴🔴🔴🔵	🔵🔵🔵🔵🔵🔵🔵

---

Found 38 known test failures

[adelapena]

@michaeljmarshall will you have time to review this? It should be a nice performance improvement for coordinators.

[michaeljmarshall]

LGTM! Sorry, I missed reviewing this sooner. I'm glad we'll be able to skip an extra sorting step in the coordinator.

[michaeljmarshall]

The two test failures labeled as regressions are for detected leaks. I commented on https://github.com/riptano/cndb/issues/11910 with a reference to this PR. They are not related to this PR, so I am going to merge this now.

[adelapena]

Thanks for reviewing and merging :). There wasn't a PR for adding this to CNDB yet, so I have created this one: https://github.com/riptano/cndb/pull/12076

That PR also includes CNDB-11950, for which I haven't found the matching PR bumping the CNDB version.