DSP-24606: Replace nulls with negative defaults in system_schema #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelapena
reviewed
Dec 5, 2024
test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java
Outdated
Show resolved
Hide resolved
test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java
Outdated
Show resolved
Hide resolved
test/unit/org/apache/cassandra/cql3/validation/operations/AggregationTest.java
Outdated
Show resolved
Hide resolved
adelapena
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Looks great, +1.
Before merging it, we'll need to create a PR in the CNDB repo updating the version of CC in pom.xml to point to the artifact produced by this PR's CI, which I think is 4.0.11-bbe0fed4ac97 for the last push. If such artifact doesn't exist, it can be manually created here.
Here is are some examples of such PRs:
Once CI for that CNDB PR verifies that this doesn't break anything in Astra, we can merge this CC PR. That will produce a new commit in the main branch and a new artifact. So we should go back to the CNDB PR, update it to point to that CC version, and merge.
This patch replaces null values of `deterministic`, `monotonic` and `monotonic_on` columns in `system_schema.functions` and `system_schema.aggregates` with negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.
szymon-miezal
force-pushed
the
DSP-24606
branch
from
bbe0fed to
45c092e
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1445 rejected by Butler1 new test failure(s) in 3 builds Found 1 new test failures
Found 17 known test failures |
djatnieks
pushed a commit
that referenced
this pull request
Dec 18, 2024
This patch replaces null values of `deterministic`, `monotonic` and `monotonic_on` columns in `system_schema.functions` and `system_schema.aggregates` with negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.
djatnieks
pushed a commit
that referenced
this pull request
Jan 17, 2025
This patch replaces null values of `deterministic`, `monotonic` and `monotonic_on` columns in `system_schema.functions` and `system_schema.aggregates` with negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.
djatnieks
pushed a commit
that referenced
this pull request
Jan 17, 2025
This patch replaces null values of `deterministic`, `monotonic` and `monotonic_on` columns in `system_schema.functions` and `system_schema.aggregates` with negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.
djatnieks
pushed a commit
that referenced
this pull request
Jan 30, 2025
This patch replaces null values of `deterministic`, `monotonic` and `monotonic_on` columns in `system_schema.functions` and `system_schema.aggregates` with negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
This patch replaces null values of `deterministic`, `monotonic` and `monotonic_on` columns in `system_schema.functions` and `system_schema.aggregates` with negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces null values of
deterministic,monotonicandmonotonic_oncolumns insystem_schema.functionsandsystem_schema.aggregateswith negative defaults. These defaults will be addressed if/once DB-672 gets ported to CC.