Skip to content

CNDB-12257: do not call System.getProperty on an hotpath (ChunkCache miss) #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

eolivelli
Copy link

What is the issue

See #12257

What does this PR fix and why was it fixed

Cache the value

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1475 rejected by Butler


2 new test failure(s) in 1 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
...t=list,wide=true,scenario=MIXED_QUERY] regression 🔴 🔵🔵🔵🔵🔵🔵🔵
...nt,varint>,wide=false,scenario=COMPACTED_QUERY] regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 3 known test failures

@jtgrabowski jtgrabowski merged commit fd6d816 into main Dec 23, 2024
457 of 472 checks passed
@jtgrabowski jtgrabowski deleted the CNDB-12257 branch December 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants