Skip to content

CNDB-12297: Fix flaky test MutatorTest.testMutatateAtomically by polling for async batchlog removal #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jkni
Copy link

@jkni jkni commented Dec 31, 2024

What is the issue

The test asserts that the batchlog is removed immediately after the write completes, but removal of the batchlog is async and can be delayed, particularly in resource-limited environments like CI.

What does this PR fix and why was it fixed

Poll for batchlog removal, giving the async process time to complete.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1485 rejected by Butler


2 new test failure(s) in 1 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
...ble,double>,wide=false,scenario=MEMTABLE_QUERY] regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 4 known test failures

@jkni jkni self-assigned this Dec 31, 2024
@jkni jkni merged commit 3780ee0 into main Jan 2, 2025
455 of 473 checks passed
@jkni jkni deleted the CNDB-12297 branch January 2, 2025 15:59
djatnieks pushed a commit that referenced this pull request Jan 3, 2025
…ing for async batchlog removal (#1485)

The test asserts that the batchlog is removed immediately after the
write completes, but removal of the batchlog is async and can be
delayed, particularly in resource-limited environments like CI.
djatnieks pushed a commit that referenced this pull request Jan 17, 2025
…ing for async batchlog removal (#1485)

The test asserts that the batchlog is removed immediately after the
write completes, but removal of the batchlog is async and can be
delayed, particularly in resource-limited environments like CI.
djatnieks pushed a commit that referenced this pull request Jan 17, 2025
…ing for async batchlog removal (#1485)

The test asserts that the batchlog is removed immediately after the
write completes, but removal of the batchlog is async and can be
delayed, particularly in resource-limited environments like CI.
djatnieks pushed a commit that referenced this pull request Jan 30, 2025
…ing for async batchlog removal (#1485)

The test asserts that the batchlog is removed immediately after the
write completes, but removal of the batchlog is async and can be
delayed, particularly in resource-limited environments like CI.
djatnieks pushed a commit that referenced this pull request May 18, 2025
…ing for async batchlog removal (#1485)

The test asserts that the batchlog is removed immediately after the
write completes, but removal of the batchlog is async and can be
delayed, particularly in resource-limited environments like CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants