CNDB-12937: enable jvector 4; remove jvector 3 write support #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
michaeljmarshall
force-pushed
the
cndb-12937
branch
from
0a2e75f to
17d0072
Compare
michaeljmarshall
force-pushed
the
cndb-12937
branch
from
17d0072 to
60c858e
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1685 rejected by Butler1 new test failure(s) in 4 builds Found 1 new test failures
Found 6 known test failures |
eolivelli
approved these changes
Apr 10, 2025
|
Tests passed in https://github.com/riptano/cndb/pull/13596, merging now. |
djatnieks
pushed a commit
that referenced
this pull request
Apr 14, 2025
riptano/cndb#12937. This is a follow up on #1676, which updated the jvector dependency but didn't update the jvector version in the actual graph builder. * Adds jvector version configuration, defaulted to 4 * Tests jvector versions 2 and 4 to ensure we can query sstables with both kinds of graphs * Makes the `enable_hierarchy` config backwards compatible by ignoring it if the jvector version is too low * Removes the ability to write FusedADC since it does not work with the latest jvector version (discovered when writing compatibility tests) * Does not remove FusedADC read path since there could be indexes based on it in production * Replaces call to deprecated `graph.size()` method with `graph.size(0)`
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
riptano/cndb#12937. This is a follow up on #1676, which updated the jvector dependency but didn't update the jvector version in the actual graph builder. * Adds jvector version configuration, defaulted to 4 * Tests jvector versions 2 and 4 to ensure we can query sstables with both kinds of graphs * Makes the `enable_hierarchy` config backwards compatible by ignoring it if the jvector version is too low * Removes the ability to write FusedADC since it does not work with the latest jvector version (discovered when writing compatibility tests) * Does not remove FusedADC read path since there could be indexes based on it in production * Replaces call to deprecated `graph.size()` method with `graph.size(0)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
https://github.com/riptano/cndb/issues/12937. This is a follow up on #1676, which updated the jvector dependency but didn't update the jvector version in the actual graph builder.
What does this PR fix and why was it fixed
enable_hierarchyconfig backwards compatible by ignoring it if the jvector version is too lowgraph.size()method withgraph.size(0)