Skip to content

HCD-147: Add createsystemkey subcommand to nodetool #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szymon-miezal
Copy link

@szymon-miezal szymon-miezal commented May 23, 2025

This commit extends nodetool with createsystemkey command.
The motivation is to allow users to create encryption keys that can
be used for flat-file based encryption in TDE.

CNDB PR: https://github.com/riptano/cndb/pull/14205.

Copy link

github-actions bot commented May 23, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

This commit extends nodetool with createsystemkey command.
The motivation is to allow users to create encryption keys that can
be used for flat-file based encryption in TDE.
@szymon-miezal szymon-miezal marked this pull request as ready for review May 23, 2025 11:47
Copy link

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1759 approved by Butler


Approved by Butler
See build details here

@bereng
Copy link
Collaborator

bereng commented May 26, 2025

IIUC your CNDB PR is not poiniting at any SHA in this CC PR?

@pkolaczk pkolaczk self-requested a review May 27, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants