-
Notifications
You must be signed in to change notification settings - Fork 13
Edit findl4jvulnerabilities #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChrisCalv
wants to merge
54
commits into
datto:main
Choose a base branch
from
ProVal-Tech:edit-findl4jvulnerabilities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of-date Bump version of log4shell from 1.3.0 to 1.6.1
…om-luna Suppress Warning Messages from Luna (log4shell) and Improve Logging
…of-get-wmiobject Replace Get-WMIObject with Get-CimInstance
Moved the log4shell and Yara scanners to Call operators and moved robocopy to same window of PowerShell so that a new console is not opened.
Move Luna and Yara to Call Operator + Robocopy -NoNewWindow Addition
Feat jndimanager md5
Add '! Alert: ' to Write-log when md5 found in bad list
Move ! Alert to after verification of lookup class Add the JarFileName to the message.
@stotler Can you please close this PR. @ChrisCalv open it erroneously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized I had the '! Alert:' in one step too high, so during this I added a new message in the section where we are verifying the Jndilookup.class file for that jar,
The logic is if we verify that that file exists two parents up then this is a valid log4j vulnerability, in this case we will write a warning with the '! Alert:' precedent followed by a message that includes the jarfile name that we are evaluating.
The log will appear as
! Alert: The MD5 hash for $jarfile was found in the bad list and the jndilookup.class file was verified to exist, this file needs to be patched.
and $jarfile is equal to the literal path of the file in which we are about to extract.