Skip to content

fix: functional test trigger fix #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

fix: functional test trigger fix #297

merged 1 commit into from
May 15, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented May 15, 2023 •
edited
Loading

Description

Functional tests are not accessing secrets from fork triggers or via dependantbot, this pr use pull_request_target at our own risk.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 merged commit c59a74b into main May 15, 2023
@nicor88 nicor88 deleted the fix/functiona_test_trigger branch May 15, 2023 07:06
@nicor88 nicor88 mentioned this pull request May 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@Jrmyy Jrmyy Awaiting requested review from Jrmyy

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

@thenaturalist thenaturalist Awaiting requested review from thenaturalist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicor88