Skip to content

fix: athena list schemas argument #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

fix: athena list schemas argument #322

merged 1 commit into from
May 23, 2023

Conversation

krisstinkou
Copy link
Contributor

Description

Fix athena__list_schemas arguments according to AthenaAdapter.list_schemas signature.

Models used to test - Optional

Checklist

  • [ x ] You followed contributing section
  • [ x ] You kept your Pull Request small and focused on a single feature or bug fix.
  • [ x ] You added unit testing when necessary
  • [ x ] You added functional testing when necessary

@krisstinkou krisstinkou changed the title Fix Athena list schemas argument fix: athena list schemas argument May 23, 2023
@krisstinkou krisstinkou marked this pull request as ready for review May 23, 2023 11:51
@Jrmyy Jrmyy merged commit 9c72c3b into dbt-labs:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrmyy Jrmyy Jrmyy approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

@nicor88 nicor88 Awaiting requested review from nicor88

@svdimchenko svdimchenko Awaiting requested review from svdimchenko

@thenaturalist thenaturalist Awaiting requested review from thenaturalist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisstinkou @Jrmyy