fix: docs generate support federated query catalogs #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiarareinaldo
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88,
svdimchenko and
thenaturalist
as code owners
Jrmyy
reviewed
May 31, 2023
Jrmyy
reviewed
Jun 1, 2023
|
@svdimchenko can you also take a look as a second pair of eyes please ? 😇 |
svdimchenko
reviewed
Jun 8, 2023
svdimchenko
reviewed
Jun 8, 2023
maiarareinaldo
force-pushed
the
support-federated-query
branch
from
dc22cd5 to
706e5d3
Compare
maiarareinaldo
force-pushed
the
support-federated-query
branch
from
706e5d3 to
916eae1
Compare
svdimchenko
reviewed
Jun 14, 2023
svdimchenko
reviewed
Jun 14, 2023
svdimchenko
reviewed
Jun 14, 2023
svdimchenko
previously approved these changes
Jun 15, 2023
svdimchenko
approved these changes
Jul 28, 2023
Jrmyy
approved these changes
Jul 31, 2023
|
@maiarareinaldo sorry I totally missed that in the 1.5.2 release - we are planning 1.6.0 release. @Jrmyy @svdimchenko you had a look already at this one - overall to me seems fine. |
nicor88
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #306
Updated
_get_one_catalogto use Glue API only if catalog is of typeGLUE, otherwise it runs theget_catalogmacro which was changed back to query information_schema.Models used to test - Optional
Checklist