Skip to content

fix: failure when config from view to Iceberg table #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 10, 2023
Merged

fix: failure when config from view to Iceberg table #367

merged 3 commits into from
Aug 10, 2023

Conversation

brabster
Copy link
Contributor

@brabster brabster commented Aug 4, 2023

Description

resolve #366

Models used to test - Optional

standard base tests

Checklist

  • [/] You followed contributing section
  • [/] You kept your Pull Request small and focused on a single feature or bug fix.
  • [/] You added unit testing when necessary
  • [/] You added functional testing when necessary

@brabster brabster changed the title WIP Add test coverage to reproduce WIP Fix failure when config from view to Iceberg table Aug 4, 2023
@brabster brabster changed the title WIP Fix failure when config from view to Iceberg table Fix failure when config from view to Iceberg table Aug 4, 2023
@brabster
Copy link
Contributor Author

brabster commented Aug 4, 2023

New tests passing, rest of suite passing - ready for review

@brabster brabster changed the title Fix failure when config from view to Iceberg table fix: failure when config from view to Iceberg table Aug 4, 2023
nicor88
nicor88 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@nicor88 nicor88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brabster to cover this edge case, @Jrmyy do you want to have another look?

@nicor88 nicor88 merged commit e1df8bd into dbt-labs:main Aug 10, 2023
@brabster brabster deleted the fix-366-view-to-iceberg-fails branch April 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicor88 nicor88 nicor88 approved these changes

@Jrmyy Jrmyy Jrmyy approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

@svdimchenko svdimchenko Awaiting requested review from svdimchenko

@thenaturalist thenaturalist Awaiting requested review from thenaturalist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switching a model from view to Iceberg table fails
3 participants
@brabster @nicor88 @Jrmyy