-
Notifications
You must be signed in to change notification settings - Fork 104
feat: lf_inherited_tags config to exclude certain tags from CRUD #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lf_inherited_tags config to exclude certain tags from CRUD #453
Conversation
Could you please fix the unit tests? |
@nicor88 Ok fixed and confirmed locally. Not sure why it's not re-running the failed checks. |
Overall the code looks OK to me with some minor adjustments. However I've left the comment in issue regarding this feature, I believe we should discuss it before proceesd with this PR. |
@dacreify could you please add models examples with corresponding configs to PR description, this will make testing process easier to reviewers |
@svdimchenko Sure added some testing steps -- see what you think |
@dacreify I've tested your changes and the feature works as expected. So let's fix the unit tests, also there are some minor comments and we are ready to go |
Co-authored-by: Serhii Dimchenko <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dacreify great job. LGTM @svdimchenko
Thanks all! |
Description
See: #452
Acceptance Testing
dbt_project.yml
, for example:+lf_inherited_tags: [my-tag]
withinmodels:
lf_tags_config
to a model to set some other tagsmy-tag
is retained instead of being removed and that additional model-level tags are associatedChecklist