Skip to content

chore: add concurrency control for functional tests #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 13, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Nov 13, 2023

Description

When running multiple functional tests in parallel we can have weird errors, this PR add concurrency control, to avoid to hit limits in AWS due to concurrency.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

Copy link
Contributor

@Jrmyy Jrmyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@nicor88 nicor88 merged commit ad7bc30 into main Nov 13, 2023
@nicor88 nicor88 deleted the chore/add_functional_tests_concurrency branch November 13, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants