fix: check for old tmp table before deleting it #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octiva
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
octiva
force-pushed
the
fine-grain-permissions-bug
branch
2 times, most recently
from
39b10d0 to
7da1c6d
Compare
|
@octiva Could you double check if we need to adapt also anything in the incremental part? maybe we can benefit for the same approach too, that seems more resilient and correct. |
nicor88
reviewed
Jan 2, 2024
dbt/include/athena/macros/materializations/models/incremental/incremental.sql
Show resolved
Hide resolved
nicor88
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Thanks for this improvement @octiva 💯
@svdimchenko / @Jrmyy could you have another look?
nicor88
reviewed
Jan 2, 2024
dbt/include/athena/macros/materializations/models/incremental/incremental.sql
Outdated
Show resolved
Hide resolved
octiva
force-pushed
the
fine-grain-permissions-bug
branch
from
62d6801 to
38937bf
Compare
Jrmyy
approved these changes
Jan 3, 2024
|
Happy to contribute! |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented as discussed in #546.
Uses
adapter.get_relationto search for an old tmp_relation that could exist if the previous table creation did not clean it up properly.Models used to test - Optional
Checklist