Simplify running the integration tests #211
Conversation
| @@ -11,7 +11,7 @@ integration_tests: | |||
| outputs: | |||
| postgres: | |||
| type: postgres | |||
| host: localhost | |||
| host: "{{ env_var('CI_DBT_HOST') }}" | |||
There was a problem hiding this comment.
This would mean btw that this environment variable would need to be set in CircleCI too, or we should put localhost as a default value, but that would not be my preference.
Now that I take another look on it, adding POSTGRES somewhere in these environment variables, e.g. CI_POSTGRES_DBT_HOST would probably make the naming more consistent in the profiles.yml
There was a problem hiding this comment.
This is just a sample file - the actual env var is set in the .circle/config.yml file! I'm supportive of this change
|
hey @bjgbeelen - this is awesome! Your PR here inspired me to play around with CircleCI's workflows. I made a branch for this over here: https://github.com/fishtown-analytics/dbt-utils/compare/pr/211-drew?expand=1 The key benefits are that:
I'm pretty happy with this PR as-is. I'm going to do one more pass here, and then this will be good to merge :) |
|
Glad you like it! Sounds like great new benefits you're investigating! |
| @@ -11,7 +11,7 @@ integration_tests: | |||
| outputs: | |||
| postgres: | |||
| type: postgres | |||
| host: localhost | |||
| host: "{{ env_var('CI_DBT_HOST') }}" | |||
There was a problem hiding this comment.
This is just a sample file - the actual env var is set in the .circle/config.yml file! I'm supportive of this change
During the development and discussion of #205 I wanted to run the integration tests against a Spark backend. To make this happen, I made some changes presented here. While adding Spark integration is something for the long run, I already did some work that I think might be valuable for others users too.
It's twofold:
I have not seen the results yet on CircleCI of course, so it might need some extra attention at things I overlooked