Ensure surrogate key handles single arg #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Nice!
Q: Do we need to cut two patch releases (0.3.1 + 0.4.1), to support surrogate_key users who have not yet upgraded to dbt v0.17.0? I'm leaning no, but thought I'd surface it, since this sort of thing will come up again in the future. The OP in #241 is on v0.17.0 so they should have a smooth upgrade from dbt-utils v0.3.0 → v0.4.1.
|
Oh yikes, I'm leaning no just for simplicity, and so more people upgrade to 0.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
Updated the tests for this case too