Minimal initial fixes for interop testing #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyers
force-pushed
the
splice_interop2
branch
2 times, most recently
from
9f83aea to
8681b7b
Compare
remyers
force-pushed
the
splice_interop2
branch
from
547ea2f to
a2d73cb
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
from
d46a049 to
30b9b45
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
15 times, most recently
from
cd71829 to
6c9979e
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
7 times, most recently
from
3fb26e3 to
8808c06
Compare
remyers
force-pushed
the
splice_interop2
branch
2 times, most recently
from
ffda0ad to
cf5d097
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
5 times, most recently
from
7df7b12 to
9b74028
Compare
This is an alternative to what we discussed on Friday to fix the interop test where we splice-out funds from cln that were received via an htlc payment. ElementsProject#8021 (comment) It should be safer to use `amount_msat_to_sat_round_down` instead of `amount_msat_to_sat` because we can drop sub-sat amounts for splices. Also if `amount_msat_to_sat` fails it won't set `local_funds` and create UB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the minimal fixes I needed for interop testing with Eclair (splicing-official-interop branch).
My interop tests are still not working but you'll want these changes to be able to repo them.