-
Notifications
You must be signed in to change notification settings - Fork 2.1k
test: create e2e
environment; stop testing spacy in unit tests
#9212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d31c441
ci: create e2e environment; stop testing spacy in unit tests
anakin87 4b0a41b
try fix
anakin87 6669da6
fix yml
anakin87 eef93a3
Merge branch 'main' into e2e-spacy
anakin87 d7a547a
exclude test python files
anakin87 5799a49
Merge branch 'e2e-spacy' of https://github.com/deepset-ai/haystack in…
anakin87 21a8988
Merge branch 'main' into e2e-spacy
anakin87 de45cf9
self-referential environment
anakin87 ed1bd90
do not use self-referential environment
anakin87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,11 @@ | ||
# SPDX-FileCopyrightText: 2022-present deepset GmbH <[email protected]> | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
# Note: We do not test the Spacy backend in this module. | ||
# Spacy is not installed in the test environment to keep the CI fast. | ||
# We test the Spacy backend in e2e/pipelines/test_named_entity_extractor.py. | ||
|
||
from haystack.utils.auth import Secret | ||
import pytest | ||
|
||
|
@@ -17,10 +22,6 @@ def test_named_entity_extractor_backend(): | |
|
||
_ = NamedEntityExtractor(backend="hugging_face", model="dslim/bert-base-NER") | ||
|
||
_ = NamedEntityExtractor(backend=NamedEntityExtractorBackend.SPACY, model="en_core_web_sm") | ||
julian-risch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
_ = NamedEntityExtractor(backend="spacy", model="en_core_web_sm") | ||
|
||
with pytest.raises(ComponentError, match=r"Invalid backend"): | ||
NamedEntityExtractor(backend="random_backend", model="dslim/bert-base-NER") | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"spacy-curated-transformers>=0.2,<=0.3",
: this is no longer needed.