test: mark more tests as slow #9296
Conversation
Pull Request Test Coverage Report for Build 14621588111Details
💛 - Coveralls |
| @@ -421,20 +423,21 @@ def test_run_small_batch_size(self, query, docs_before_texts, expected_first_tex | |||
|
|
|||
| # Returns an empty list if no documents are provided | |||
| @pytest.mark.integration | |||
| @pytest.mark.slow | |||
There was a problem hiding this comment.
@anakin87 could be out of scope for this PR, but this test could be made into a unit test with a patch on the warm_up method.
Maybe worth noting down somewhere which of these tests could be made into unit tests?
| def test_raises_component_error_if_model_not_warmed_up(self): | ||
| sampler = TransformersSimilarityRanker() | ||
| with pytest.raises(RuntimeError): | ||
| sampler.run(query="query", documents=[Document(content="document")]) | ||
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.slow | ||
| @pytest.mark.parametrize( | ||
| "query,docs_before_texts,expected_first_text", | ||
| [ |
There was a problem hiding this comment.
To slightly help with speed I don't think there is any reason we should be parametrizing the tests in this file. Doing just one is enough to test the behavior. We don't need to run three which should also help save on cpu inference time.
| @@ -378,6 +379,7 @@ def test_run(self, query, docs_before_texts, expected_first_text, scores): | |||
| assert docs_after[2].score == pytest.approx(sorted_scores[2], abs=1e-6) | |||
|
|
|||
| @pytest.mark.integration | |||
| @pytest.mark.slow | |||
There was a problem hiding this comment.
Same as mentioned below, no need to have multiple parametrized tests here, could just be one.
| @@ -336,6 +336,7 @@ def __init__(self): | |||
| assert ranker.device == ComponentDevice.from_multiple(DeviceMap.from_hf({"layer_1": 1, "classifier": "cpu"})) | |||
|
|
|||
| @pytest.mark.integration | |||
| @pytest.mark.slow | |||
There was a problem hiding this comment.
Same comment here on reducing number of parametrized tests to one.
Related Issues
Proposed Changes:
How did you test it?
CI
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.