Skip to content

fix(bytes): allow to concat() readonly arrays of bytes arrays #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

ngasull
Copy link
Contributor

@ngasull ngasull commented May 5, 2025

concat currently only allows mutable arrays whereas it doesn't mutate its input.

This PR expands the signature to read-only arrays.

Doesn't refer to any open issue.

@ngasull ngasull requested a review from kt3k as a code owner May 5, 2025 09:22
@CLAassistant
Copy link

CLAassistant commented May 5, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bytes label May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (6a00d6c) to head (81380a2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6639   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         584      584           
  Lines       46563    46563           
  Branches     6541     6541           
=======================================
+ Hits        44119    44120    +1     
+ Misses       2401     2400    -1     
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit c338b2f into denoland:main May 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants