wait for profile comp transaction to broadcast before signing and submitting UpdateProfile transaction #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mitting UpdateProfile transaction
maebeam
reviewed
Dec 1, 2021
src/app/backend-api.service.ts
Outdated
| @@ -1251,7 +1251,40 @@ export class BackendApiService { | |||
| NewStakeMultipleBasisPoints, | |||
| IsHidden, | |||
| MinFeeRateNanosPerKB, | |||
| }); | |||
| }).pipe( | |||
| map((res) => { | |||
There was a problem hiding this comment.
What is this code doing? I see that it checks for the txn but then what?
There was a problem hiding this comment.
If we have a CompProfileCreatoinTxnHashHex, poll the get-txn endpoint until TxnFound is true. Once found, return the response from UpdateProfile
There was a problem hiding this comment.
I could be misreading this code because it's on github and I can't read indentations but I'm not sure I understand how this accomplishes that
There was a problem hiding this comment.
I rewrote it with observables. it works as follows:
- Construct the transaction using the update-profile endpoint
- If the response has a
CompProfileCreationTxnHashHex, then start polling every half second for the transaction for a minute, take the first instance whereTxnFoundistrueand pipe the response from the update-profile request thru. - If the response does not have a
CompProfileCreationTxnHashHex, pipe the response from the update-profile request thru immediately - sign and submit the transaction by using the piped response from steps 2 or 3.
maebeam
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.