EES-5908 enhance healthchecks #5676
Conversation
leeoades
force-pushed
the
EES-5908-Enhance-healthchecks
branch
from
6f578a1 to
ae42fab
Compare
leeoades
force-pushed
the
EES-5908-Enhance-healthchecks
branch
from
ae42fab to
b63f6d9
Compare
Add Heathchecks for Content API and Azure Storage . Renamed Healthy to IsHealthy. Add sln just for Search function app Azure Healthcheck needs to catch exceptions too Add logging to Azure Blob Storage Client - mainly to catch the annoying metadata issues
leeoades
force-pushed
the
EES-5908-Enhance-healthchecks
branch
from
b63f6d9 to
87ae394
Compare
....Search.FunctionApp/Functions/HealthChecks/Strategies/AzureBlobStorageHealthCheckStrategy.cs
Outdated
Show resolved
Hide resolved
...xploreEducationStatistics.Content.Search.FunctionApp/Clients/ContentApi/IContentApiClient.cs
Outdated
Show resolved
Hide resolved
...EducationStatistics.Content.Search.FunctionApp/Functions/HealthChecks/HealthCheckFunction.cs
Outdated
Show resolved
Hide resolved
...ExploreEducationStatistics.Content.Search.FunctionApp/Clients/ContentApi/ContentApiClient.cs
Outdated
Show resolved
Hide resolved
...reEducationStatistics.Content.Search.FunctionApp.Tests/Builders/HeathCheckStrategyBuilder.cs
Outdated
Show resolved
Hide resolved
...tatistics.Content.Search.FunctionApp.Tests/Functions/HeathChecks/HealthCheckFunctionTests.cs
Outdated
Show resolved
Hide resolved
...tatistics.Content.Search.FunctionApp.Tests/Functions/HeathChecks/HealthCheckFunctionTests.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Content.Search.FunctionApp.Tests/ProgramTests.cs
Outdated
Show resolved
Hide resolved
…oving an unnecessary connection string
| @@ -2445,7 +2446,7 @@ public async Task ListLatestReleaseVersions_SingleRelease() | |||
| Assert.Equal(releaseVersion.Release.TimePeriodCoverage, summaryViewModel.TimePeriodCoverage); | |||
| Assert.Equal(releaseVersion.Published, summaryViewModel.Published); | |||
| Assert.Equal(releaseVersion.Live, summaryViewModel.Live); | |||
| Assert.Equal(releaseVersion.PublishScheduled, summaryViewModel.PublishScheduled); | |||
| Assert.Equal(releaseVersion.PublishScheduled?.ConvertUtcToUkTimeZone(), summaryViewModel.PublishScheduled); | |||
There was a problem hiding this comment.
I think you need to make a similar change in GovUk.Education.ExploreEducationStatistics.Admin.Tests.Services.ManageContent.ManageContentPageServiceTests.GetManageContentPageViewModel because that test is also failing.
I was surprised that we don't also have the same issue in GovUk.Education.ExploreEducationStatistics.Admin.Tests.Services.ReleaseVersionServiceTests.GetReleaseTests.Success because we do exactly the same thing in the mapping to build the ReleaseVersionViewModel view model as we do here for the ReleaseVersionSummaryViewModel.
I investigated this and found that the difference is in how the data is being set up for the Published release version. In this test which isn't failing, the release version has no value of PublishScheduled. We could still make the same change though, with the null-forgiving operator like you've done here.
I also looked into why this started failing yesterday and noticed that today the date generated is 2024-04-01 and yesterday it was 2024-03-31. In 2024 BST began on 2024-03-31.
benoutram
force-pushed
the
EES-5908-Enhance-healthchecks
branch
from
1c5a249 to
7e8ba6d
Compare
…ted data to UK timezone with ConvertUtcToUkTimeZone to match how PublishScheduled is set up in the view model by MappingProfile which uses ConvertUtcToUkTimeZone
benoutram
force-pushed
the
EES-5908-Enhance-healthchecks
branch
2 times, most recently
from
9e61221 to
efa18b5
Compare
New Search Function App