EES-5943 Fix delete ancillary file modal focus restoration #5697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor modal to be on each file rather than in the top level section. This lets us use the triggerButton for handling focus.
amyb-hiveit
requested changes
Mar 20, 2025
| @@ -80,7 +87,21 @@ export default function AncillaryFileSummaryList({ | |||
| > | |||
| Edit file | |||
| </Link> | |||
| <ButtonText onClick={onDelete}>Delete file</ButtonText> | |||
| <ModalConfirm | |||
| open={deleteFile && deleteFile.id === file.id} | |||
There was a problem hiding this comment.
deleteFile isn't being passed in from ReleaseFileUploadsSection so I don't think this is needed.
There was a problem hiding this comment.
Good catch, I thought I was passing that through and that was determining whether the modal was open! Apparently not.. Will remove here.
amyb-hiveit
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the "delete supporting file upload" modal to be rendered for each file rather than shared in the top level section.
This lets us use the
triggerButtonfor handling focus, so focus can be restored to the 'Delete file' button when the modal is closed.