EES-5910 Ensure tooltips visible when tabbing through map regions #5713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennettstuart
approved these changes
Mar 24, 2025
| @@ -107,6 +106,8 @@ export default function MapGeoJSON({ | |||
| } | |||
| }, [map, selectedFeature]); | |||
|
|
|||
| const resetZoom = () => map.setZoom(5); | |||
There was a problem hiding this comment.
Do we need to reset the position also? the default position is available in the parent component so could be used if so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where tooltips were sometimes not visible when tabbing through regions of a map block.
We detect tab presses and zoom the map out when this happens.
N.B I have also added handling for user pressing 'Enter' when focussing on a region, to 'select' the region and display the key stat block. If you think that is out of scope for this ticket or otherwise not wanted, let me know and I will remove it.