-
Notifications
You must be signed in to change notification settings - Fork 5
EES-5733 Table export options #5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
reviewed
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some initial comments. Also:
- I think the button needs to be in a consistent position with the Chart version. In your screenshot it's showing the 'move and reorder headers' button, but that should only show when you're editing a data block, where we don't need to show the export button, so I think it could be on the right.
- I'm getting an error on the front end site when try to download the ODS or copy to clipboard -
TypeError: Cannot read properties of null (reading 'current')
ontableRef
in downloadTableOdsFile.ts (168:16)
src/explore-education-statistics-common/src/table/components/ExportTableButton.module.scss
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/table/components/TableExportButton.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/table/components/TableExportButton.tsx
Outdated
Show resolved
Hide resolved
e232ece
to
712672f
Compare
eeb9d38
to
53d4739
Compare
53d4739
to
19fe49c
Compare
bennettstuart
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds export as ODS and CSV and copy to clipboard options to data block tables. To be consistent with the table tool download options the CSV downloads the table data as a flat file with location codes
Also,