Skip to content

EES-5733 Table export options #5728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 4, 2025
Merged

Conversation

rianski
Copy link
Collaborator

@rianski rianski commented Mar 27, 2025

Adds export as ODS and CSV and copy to clipboard options to data block tables. To be consistent with the table tool download options the CSV downloads the table data as a flat file with location codes

Also,

  • added a copy table to clipboard option to permalink pages and final step of table tool.
  • removed the export menu on charts when viewing / editing a data block in the data blocks tab, including in the chart builder.
  • removed the context used for the chart export as it wasn't really necessary, I think it was originally intended to be used when the table export was added but wasn't, so it's simpler to just pass the ref in.

@rianski rianski changed the title EES-7733 (DRAFT) commit initial table export for data block EES-5733 (DRAFT) commit initial table export for data block Mar 27, 2025
@rianski rianski changed the title EES-5733 (DRAFT) commit initial table export for data block EES-5733 (DRAFT) Table export options Mar 27, 2025
Copy link
Collaborator

@amyb-hiveit amyb-hiveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some initial comments. Also:

  • I think the button needs to be in a consistent position with the Chart version. In your screenshot it's showing the 'move and reorder headers' button, but that should only show when you're editing a data block, where we don't need to show the export button, so I think it could be on the right.
  • I'm getting an error on the front end site when try to download the ODS or copy to clipboard - TypeError: Cannot read properties of null (reading 'current') on tableRef in downloadTableOdsFile.ts (168:16)

@amyb-hiveit amyb-hiveit force-pushed the EES-5733-download-copy-tables branch from e232ece to 712672f Compare April 3, 2025 14:29
@amyb-hiveit amyb-hiveit marked this pull request as ready for review April 3, 2025 14:30
@amyb-hiveit amyb-hiveit force-pushed the EES-5733-download-copy-tables branch 2 times, most recently from eeb9d38 to 53d4739 Compare April 3, 2025 14:36
@amyb-hiveit amyb-hiveit force-pushed the EES-5733-download-copy-tables branch from 53d4739 to 19fe49c Compare April 3, 2025 15:11
@amyb-hiveit amyb-hiveit changed the title EES-5733 (DRAFT) Table export options EES-5733 Table export options Apr 3, 2025
@bennettstuart bennettstuart merged commit 28ebdb3 into dev Apr 4, 2025
11 checks passed
@bennettstuart bennettstuart deleted the EES-5733-download-copy-tables branch April 4, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants