Skip to content

EES-5974 infrastructure changes for search function app related to EES-5875 #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benoutram
Copy link
Collaborator

This PR makes infrastructure changes for the Search Azure Function App to support changes made to it in EES-5875 by #5703. These changes are possible now that the configuration for the Azure AI Search resource was added by #5733.

  • Rename the indexName app setting and parameter names to indexerName to match Azure's SearchIndexerClient class since the operation to retrieve indexer information requires the indexer name rather than the index name.
  • Configure the app with the Azure AI search REST API endpoint.
  • Configure the app with the Azure AI search indexer name.
  • Enable the app's search indexer health check by uncommenting AzureSearchHealthCheckStrategy.
  • Assign the app's system managed identity the 'Search Service Contributor' role required to list indexers.
  • Break out a new searchServiceRoleAssignment template and refactor searchServiceConfig to use it.

Updated health check response after deploying these changes:

image

@benoutram benoutram requested a review from leeoades April 2, 2025 14:03
Copy link
Collaborator

@leeoades leeoades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely amazing stuff, Ben! Ship it!!

@benoutram benoutram merged commit a6dbe49 into dev Apr 2, 2025
7 checks passed
@benoutram benoutram deleted the EES-5974-Infrastructure-changes-for-Search-Function-App branch April 2, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants