EES-5962 On Release Slug changed - Event Handler Function #5750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoutram
reviewed
Apr 3, 2025
...tion.ExploreEducationStatistics.Content.Search.FunctionApp/Services/EventGridEventHandler.cs
Outdated
Show resolved
Hide resolved
Comment on lines
-46
to
-48
| <ItemGroup> | ||
| <Using Include="System.Threading.ExecutionContext" Alias="ExecutionContext" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
According to the docs on functions running with the isolated worker model, we should add this. Just wondering what's the reason for removing it?
There was a problem hiding this comment.
Yeah, this is odd. It's causing an error on my solution analysis. I've restored it.
....Search.FunctionApp/Functions/RefreshSearchableDocument/RefreshSearchableDocumentFunction.cs
Outdated
Show resolved
Hide resolved
Comment on lines
-5
to
+9
| public required string PublicationSlug { get; init; } | ||
| public required Guid ReleaseId {get;init;} | ||
| public required string ReleaseSlug { get; init; } | ||
| public required Guid ReleaseVersionId { get; init; } | ||
| public required string BlobName { get; init; } | ||
| public string? PublicationSlug { get; init; } | ||
| public Guid? ReleaseId {get;init;} | ||
| public string? ReleaseSlug { get; init; } | ||
| public Guid? ReleaseVersionId { get; init; } | ||
| public string? BlobName { get; init; } |
There was a problem hiding this comment.
Looks like these could stay as required and non optional, because I think the only place where we create one we are guaranteed to have all the values?
There was a problem hiding this comment.
These messages come from the queue so there's no guarantee of their contents. Better to code defensively and acknowledge that than to assume it will always be ok (== guarantee that it won't always be!)
...arch.FunctionApp/Functions/OnReleaseVersionPublished/Dtos/ReleaseVersionPublishedEventDto.cs
Outdated
Show resolved
Hide resolved
...ExploreEducationStatistics.Content.Search.FunctionApp/Clients/ContentApi/ContentApiClient.cs
Outdated
Show resolved
Hide resolved
…lls into the properties whether you like it or not) Added On Release Slug changed event handler function. Also made all properties for the dtos nullable since the serialiser will not respect the "required" keyword. Added event handler OnReleaseSlugChanged. Added Tests for all of the functions.
leeoades
force-pushed
the
EES-5962-on-release-slug-changed-functions
branch
from
6d01098 to
f31e75f
Compare
benoutram
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the final part of this ticket, added a new event handler function app for receiving and handling OnReleaseSlugChanged events.
Added On Release Slug changed event handler function.
Added event handler OnReleaseSlugChanged.
Made all properties for the dtos nullable since the serialiser will not respect the "required" keyword.
Added null guards where appropriate
Added Tests for all of the functions.