EES-5952 Add infrastructure for Event Grid topic subscriptions #5773
Conversation
...structure/templates/common/components/event-grid/eventGridCustomTopicQueueSubscription.bicep
Show resolved
Hide resolved
| @maxLength(64) | ||
| param name string | ||
|
|
||
| @description('The name of the parent topic.') |
There was a problem hiding this comment.
Is the word "parent" necessary here? Perhaps "the name of the event grid topic to which this subscription is subscribed" or words to that effect?
There was a problem hiding this comment.
No it's not necessary 🙂 . I only used the word "parent" because they refer to it as the parent in some of the descriptions of properties in the Bicep resource template documentation. I've renamed this now to "The Event Grid topic name associated with the subscription."
I also found that my formatter in VS code wasn't set up correctly so I've done a limited amount of reformatting at the same time.
infrastructure/templates/search/application/searchDocsFunctionEventSubscriptions.bicep
Show resolved
Hide resolved
| @@ -15,3 +15,14 @@ type ResourceNames = { | |||
| @export() | |||
| // The built in Search Service roles. See https://learn.microsoft.com/en-gb/azure/role-based-access-control/built-in-roles/ai-machine-learning | |||
| type SearchServiceRole = 'Search Index Data Contributor' | 'Search Index Data Reader' | 'Search Service Contributor' | |||
|
|
|||
| @export() | |||
| type StorageQueueNamesType = { | |||
There was a problem hiding this comment.
I think, because this is so specific to search, call this type SearchStorageQueueNames?
Is the Type suffix a thing in bicep?
There was a problem hiding this comment.
No I don't think it's specific to use that as a suffix but a lot of the documentation on custom types has it in examples.
I've removed it for now to make it in keeping with our other custom types, and also renamed it SearchStorageQueueNames as suggested.
benoutram
force-pushed
the
EES-5952-Automate-creation-of-event-grid-subscriptions
branch
from
e542289 to
9acaf8a
Compare
benoutram
deleted the
EES-5952-Automate-creation-of-event-grid-subscriptions
branch
This PR follows on from #5768 which added Event Grid topics that the Admin and Publisher will use to publish events when certain conditions occur.
This PR subscribes the Search Function app to these topics.
Because the functions in the Search Function app have been configured to use queue trigger bindings rather than Event Grid trigger bindings, the Event Grid subscriptions are created using the storage queues as their destinations.