Skip to content

EES-5939 'add block/section' button focus behaviour #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025

Conversation

Guy-HiveIT
Copy link
Collaborator

This PR fixes multiple focus-related issues for the release and methodology content pages.

Currently, many buttons which add items or show/close modals don't move the focus, so screen reader users can't see any change has happened, and keyboard users have to tab to access the next logical action.

  • When adding a new content section, move focus to the added section accordion item, ready to expand it.
  • When adding a data block to a section, move focus to the newly-appeared data block select (this change affects more places but all with this desired behaviour)
  • When closing the embed URL modal on cancel or escape, move focus back to the 'Embed a URL' button
  • When adding a new text block, move focus to the added block's 'Edit block' button, ready to edit the new block.

@bennettstuart bennettstuart merged commit 480e65e into dev Apr 15, 2025
11 checks passed
@bennettstuart bennettstuart deleted the EES-5939-add-block-section-button-focus-behaviour branch April 15, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants