Improve authorization flow communication and analytics #3061
+23
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tics to cover all error cases.
lmuntaner
approved these changes
May 2, 2025
| "wrong_place": "Wrong place", | ||
| "no_request_received": "Seems you arrived here for authentication, but no service has requested it.", | ||
| "missing_request": "Missing request", | ||
| "no_request_received": "We couldn't process your authentication request. Try a different browser; if the issue persists, contact the developer.", |
There was a problem hiding this comment.
Should we add that the "The browser blocked the connection with the application. Try a different browser; if the issue persists, contact the developer." or more generic "There was an issue connecting with the application. Try a different browser..."?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message shown to users in the authorization flow and extend analytics to cover all error cases.
Changes