feat: adds support for subnetId in all subnet types #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanosdev
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Similarly here, please revert the manual change to the changelog.
Adding the subnet id in the public types isn't sufficient, it needs to be mapped to the internal type and passed onto the PocketIC Server.
It would also be great to cover this in the tests. Changing one of the example tests to use a specified subnet Id should do it.
krpeacock
force-pushed
the
kaia/SDK-1982-specifying-subnet-id
branch
from
4ef683e to
bce08a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.