Skip to content

eclipse-base and eclipse-wtp refactoring #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 4, 2020
Merged

eclipse-base and eclipse-wtp refactoring #533

merged 14 commits into from
Mar 4, 2020

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Mar 2, 2020

This PR provides a refactoring of eclipse-base configuration aiming to make the configuration more readable and thread save.
Further more the configuration provides support for Eclipse bundles without activator, as for example required by org.eclipse.core.filesystem 1.7.600.

The eclipse-base changes are applied on WTP. Furthermore WTP has been refactored to disallow multiple instantiations with different configurations. The previous approach was not thread save as reported in #492

For demonstration purpose, the new eclipse-base configuration has been applied on all other eclipse formatters as well.

Note that for building eclipse-base sub-project has to be published first.
As result of this PR the new versions of eclipse-base and eclipse-wtp shall be published on maven central.

@fvgh fvgh requested a review from nedtwigg March 2, 2020 08:00
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Ready for me to publish? Also, are you okay if I adopt spotless-changelog in these _ext projects? The main change would be:

  • instead of ### Version x.x.x - TBD it would be ## Unreleased
  • when we publish to maven central, the tooling will automatically replace with ## [3.2.2] - 2020-03-02

Relatively small change, but takes one little bit of administrivia out of the equation.

@fvgh
Copy link
Member Author

fvgh commented Mar 3, 2020

@nedtwigg
I applied spotless-changelog, please have a last look at 8e2c7c7.
Not sure when you update the log (on branch or master).
Feel free to merge and publish (eclipse-base and eclipse-wtp) in which order (publish/merge) you prefer.
As soon as the new versions are available, I'll provide an update for lib-extra, fixing #492.

@nedtwigg
Copy link
Member

nedtwigg commented Mar 4, 2020

Sorry it took me so long, and sorry I broke the build for a bit in the middle. Publishing logic is always a little tricky to test :)

@fvgh fvgh merged commit 1f77549 into master Mar 4, 2020
@fvgh fvgh deleted the eclipse_base branch March 4, 2020 17:38
@nedtwigg
Copy link
Member

nedtwigg commented Mar 5, 2020

Just FYI, I merged this history into master, so that the published tags are ancestors of master.

@fvgh
Copy link
Member Author

fvgh commented Mar 5, 2020

@nedtwigg I see the point. But in this case it would be better next time to merge accepted changes first and than do the publishing, wouldn't it?

@nedtwigg
Copy link
Member

nedtwigg commented Mar 5, 2020

I think you are correct, and I will do it that way from now on.

Now that we have adopted spotless-changelog, it will be possible for us to cut a release using CircleCI triggers. I haven't used it before, but I think there would be a committer-only dashboard, and you could push the "release eclipse-base" button, and it would calculate the version, publish to mavenCentral, bump the changelog, tag, and push. It's a nice blend between automatic and manual.

Not sure when I'll have a chance to work on the CircleCI thing, but that is the motivation behind the churn I introduced with spotless-changelog.

@fvgh
Copy link
Member Author

fvgh commented Mar 5, 2020

Interesting. Like to see it running.

@nedtwigg
Copy link
Member

Released in x.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants