-
Notifications
You must be signed in to change notification settings - Fork 466
eclipse-base and eclipse-wtp refactoring #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Ready for me to publish? Also, are you okay if I adopt spotless-changelog in these _ext
projects? The main change would be:
- instead of
### Version x.x.x - TBD
it would be## Unreleased
- when we publish to maven central, the tooling will automatically replace with
## [3.2.2] - 2020-03-02
Relatively small change, but takes one little bit of administrivia out of the equation.
@nedtwigg |
…gelog. Also bump minimum eclipse-base to 3.3.0, since that is the version number of eclipse-base we are about to release.
…reuse the "hook changelog" logic.
Sorry it took me so long, and sorry I broke the build for a bit in the middle. Publishing logic is always a little tricky to test :) |
Just FYI, I merged this history into master, so that the published tags are ancestors of master. |
@nedtwigg I see the point. But in this case it would be better next time to merge accepted changes first and than do the publishing, wouldn't it? |
I think you are correct, and I will do it that way from now on. Now that we have adopted Not sure when I'll have a chance to work on the CircleCI thing, but that is the motivation behind the churn I introduced with spotless-changelog. |
Interesting. Like to see it running. |
Released in |
This PR provides a refactoring of eclipse-base configuration aiming to make the configuration more readable and thread save.
Further more the configuration provides support for Eclipse bundles without activator, as for example required by org.eclipse.core.filesystem 1.7.600.
The eclipse-base changes are applied on WTP. Furthermore WTP has been refactored to disallow multiple instantiations with different configurations. The previous approach was not thread save as reported in #492
For demonstration purpose, the new eclipse-base configuration has been applied on all other eclipse formatters as well.
Note that for building
eclipse-base
sub-project has to be published first.As result of this PR the new versions of
eclipse-base
andeclipse-wtp
shall be published on maven central.