Skip to content

docs(MessageReference): Fix static link #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2021
Merged

docs(MessageReference): Fix static link #7041

merged 2 commits into from
Dec 1, 2021

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

First of all, {@link MessageFlags#FLAGS message flag}) is an invalid redirect as it's a static link. Instead of correcting it, I removed the extra description as it seemed to fit the others. Feel free to request changes to only correct the redirect instead.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@ImRodry
Copy link
Contributor

ImRodry commented Nov 26, 2021 •
edited
Loading

IS_CROSSPOST is not a message type therefore we cannot say this like this. I think the static issue is something that needs to be fixed on the website instead but the link still redirects to the correct page, just not the correct method, so it’s no big deal and I don’t think this PR is needed

@Jiralite
Copy link
Member Author

IS_CROSSPOST is not a message type therefore we cannot say this like this.

Understood!

I think the static issue is something that needs to be fixed on the website instead but the link still redirects to the correct page, just not the correct method

No this is not correct. To reference something that's static, it needs to be joined with . To reference something that's from the instance, it needs to be joined with #. To reference something that's an event, it needs to be referenced with event:.

@ImRodry
Copy link
Contributor

ImRodry commented Nov 26, 2021

Was this tested?

@Jiralite Jiralite changed the title docs(MessageReference): Remove message type description inconsistency docs(MessageReference): Fix static link Dec 1, 2021
@iCrawl iCrawl added this to the Version 13.4 milestone Dec 1, 2021
@iCrawl iCrawl merged commit 85e6812 into discordjs:main Dec 1, 2021
@Jiralite Jiralite deleted the s-thing branch December 1, 2021 11:27
Koyamie added a commit to Koyamie/discord.js that referenced this pull request Dec 2, 2021
@Koyamie
Squashed commit of the following:
7dbc566 
commit 01f8d1b
Author: Jiralite <[email protected]>
Date:   Thu Dec 2 13:29:54 2021 +0000

    types(Interaction): Narrow `memberPermissions` (discordjs#7054)

commit 5fcda73
Author: That_Guy977 <[email protected]>
Date:   Thu Dec 2 20:29:21 2021 +0700

    fix(GuildChannel): default to `this.rawPosition` in `clone()` (discordjs#7057)

commit 552d89f
Author: Rodry <[email protected]>
Date:   Wed Dec 1 11:40:49 2021 +0000

    feat(Guild): add premiumProgressbarEnabled (discordjs#6887)

    Co-authored-by: Vlad Frangu <[email protected]>

commit b183a8e
Author: Rodry <[email protected]>
Date:   Wed Dec 1 11:33:28 2021 +0000

    docs(Invite): add info blocks for missing props (discordjs#7014)

commit da86bd4
Author: Suneet Tipirneni <[email protected]>
Date:   Wed Dec 1 06:33:11 2021 -0500

    fix: Interaction channel type should be `GuildTextBasedChannels` when in guild (discordjs#6998)

commit c07207f
Author: That_Guy977 <[email protected]>
Date:   Wed Dec 1 18:32:13 2021 +0700

    fix(Util): fix sorting for GuildChannels (discordjs#7002)

commit 4fe063f
Author: GrapeColor <[email protected]>
Date:   Wed Dec 1 20:31:37 2021 +0900

    feat: add `UserContextMenuInteraction` and `MessageContextMenuInteraction` (discordjs#7003)

    Co-authored-by: Rodry <[email protected]>
    Co-authored-by: Suneet Tipirneni <[email protected]>
    Co-authored-by: Vlad Frangu <[email protected]>
    Co-authored-by: GrapeColor <[email protected]>

commit a39d8c4
Author: Suneet Tipirneni <[email protected]>
Date:   Wed Dec 1 06:28:22 2021 -0500

    Revert "types(ApplicationCommandManager): Deprecate old `*Data` type …usages and allow camel cased dapi types to be used (discordjs#7052)

commit 85e6812
Author: Jiralite <[email protected]>
Date:   Wed Dec 1 11:27:24 2021 +0000

    docs(MessageReference): Fix static link (discordjs#7041)

commit e305156
Author: Suneet Tipirneni <[email protected]>
Date:   Mon Nov 29 13:32:26 2021 -0500

    chore: bump deps (discordjs#7048)

commit 374f970
Author: Antonio Román <[email protected]>
Date:   Mon Nov 29 11:20:52 2021 +0100

    chore: add myself as contributor in package.json (discordjs#7037)

commit e59fac3
Author: Antonio Román <[email protected]>
Date:   Mon Nov 29 11:20:18 2021 +0100

    refactor(SnowflakeUtil): clean up utils and improve perf (discordjs#7036)

commit fd63139
Author: Antonio Román <[email protected]>
Date:   Mon Nov 29 11:19:32 2021 +0100

    fix(MessageManager): do not use `client.emojis` (discordjs#7039)

commit 0193efa
Author: Antonio Román <[email protected]>
Date:   Mon Nov 29 11:19:21 2021 +0100

    fix(ActionsManager): revert to manual requires (discordjs#7034)

commit fabd343
Author: Antonio Román <[email protected]>
Date:   Mon Nov 29 11:18:41 2021 +0100

    fix(MessagePayload): prevent spread of `undefined` (discordjs#7029)

commit 2c91c48
Author: Suneet Tipirneni <[email protected]>
Date:   Mon Nov 29 05:17:57 2021 -0500

    types(ApplicationCommandManager): Deprecate old `*Data` type usages and allow camel cased dapi types to be used (discordjs#6959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
documentation semver:patch
Projects
discord.js
Archived in project
Milestone
Version 13.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @ImRodry @iCrawl @SpaceEEC