Skip to content

Wellknownportsupdate #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Conversation

rqueztech
Copy link

Description

Updated well known ports. Verified through python script which ports were missing.

Fixes # (issue)
Added new ports (47 new ports)

Type of change

Data entry, missing records

Please delete options that are not relevant.

  • [ x] New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested through running program. Not sure how up to date tests are, I think it breaks formatting rules with use of dashes but I see this has been used in other spots.

  • [ x] Running existing test

Checklist:

  • [ x] My code has been linted (make lint)
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • [ x] I have rebased my branch to include the latest changes from master

If there are issues, please feel free to contact me. I apologize if I may have overlooked something as I am still somewhat new to this. Thank you for letting me contribute previously! Cheers!

Copy link
Owner

@dnnrly dnnrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for leaving this for so long - back from holiday now so can pay attention again.

@dnnrly dnnrly merged commit 0021abb into dnnrly:master Jun 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants