Skip to content

Add node.js v10, chakracore v10, update chakracore v8 #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Apr 26, 2018

Tags: 10.0.0-wheezy, 10.0-wheezy
Architectures: amd64
GitCommit: 80814e984e9faa5e9195f9a61632e1898f6633d9
Directory: 10/wheezy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still including wheezy even in this whole new major version? Intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we haven't move to the new version yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have stretch here, so we can kill wheezy. We'll be dropping wheezy altogether in a week anyways nodejs/docker-node#567

Copy link
Contributor

@chorrell chorrell Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an open PR to Drop Wheezy in May. I'd rather see this go through now and deal with wheezy later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, although it seems a tad silly to merge a new wheezy now to remove it in a week. 😄

@tianon
Copy link
Member

tianon commented Apr 27, 2018

Diff:
diff --git a/_bashbrew-arches b/_bashbrew-arches
index 40b9d15..d89af3c 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1,3 +1,28 @@
+node:10.0 @ amd64
+node:10.0 @ arm32v7
+node:10.0 @ arm64v8
+node:10.0 @ i386
+node:10.0 @ ppc64le
+node:10.0 @ s390x
+node:10.0-alpine @ amd64
+node:10.0-alpine @ arm32v6
+node:10.0-alpine @ arm64v8
+node:10.0-alpine @ i386
+node:10.0-alpine @ ppc64le
+node:10.0-alpine @ s390x
+node:10.0-slim @ amd64
+node:10.0-slim @ arm32v7
+node:10.0-slim @ arm64v8
+node:10.0-slim @ i386
+node:10.0-slim @ ppc64le
+node:10.0-slim @ s390x
+node:10.0-stretch @ amd64
+node:10.0-stretch @ arm32v7
+node:10.0-stretch @ arm64v8
+node:10.0-stretch @ i386
+node:10.0-stretch @ ppc64le
+node:10.0-stretch @ s390x
+node:10.0-wheezy @ amd64
 node:alpine @ amd64
 node:alpine @ arm32v6
 node:alpine @ arm64v8
@@ -84,6 +109,7 @@ node:carbon-stretch @ ppc64le
 node:carbon-stretch @ s390x
 node:carbon-wheezy @ amd64
 node:chakracore @ amd64
+node:chakracore-10.0 @ amd64
 node:latest @ amd64
 node:latest @ arm32v7
 node:latest @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index 5eb4349..2fb26f3 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -70,6 +70,16 @@ node:9.11.1-onbuild
 node:9.11.1-slim
 node:9.11.1-stretch
 node:9.11.1-wheezy
+node:10.0
+node:10.0-alpine
+node:10.0-slim
+node:10.0-stretch
+node:10.0-wheezy
+node:10.0.0
+node:10.0.0-alpine
+node:10.0.0-slim
+node:10.0.0-stretch
+node:10.0.0-wheezy
 node:alpine
 node:argon
 node:argon-alpine
@@ -91,8 +101,10 @@ node:carbon-stretch
 node:carbon-wheezy
 node:chakracore
 node:chakracore-8
-node:chakracore-8.10
-node:chakracore-8.10.0
+node:chakracore-8.11
+node:chakracore-8.11.1
+node:chakracore-10.0
+node:chakracore-10.0.0
 node:latest
 node:onbuild
 node:slim
diff --git a/node_argon-alpine/Dockerfile b/node_10.0-alpine/Dockerfile
similarity index 97%
copy from node_argon-alpine/Dockerfile
copy to node_10.0-alpine/Dockerfile
index 630feaf..6b470a5 100644
--- a/node_argon-alpine/Dockerfile
+++ b/node_10.0-alpine/Dockerfile
@@ -1,6 +1,6 @@
-FROM alpine:3.4
+FROM alpine:3.7
 
-ENV NODE_VERSION 4.9.1
+ENV NODE_VERSION 10.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
@@ -45,7 +45,7 @@ RUN addgroup -g 1000 node \
     && rm -Rf "node-v$NODE_VERSION" \
     && rm "node-v$NODE_VERSION.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \
   && for key in \
diff --git a/node_boron-slim/Dockerfile b/node_10.0-slim/Dockerfile
similarity index 98%
copy from node_boron-slim/Dockerfile
copy to node_10.0-slim/Dockerfile
index 3ad5aa6..9bb00e6 100644
--- a/node_boron-slim/Dockerfile
+++ b/node_10.0-slim/Dockerfile
@@ -20,7 +20,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 6.14.1
+ENV NODE_VERSION 10.0.0
 
 RUN buildDeps='xz-utils' \
     && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
@@ -45,7 +45,7 @@ RUN buildDeps='xz-utils' \
     && apt-get purge -y --auto-remove $buildDeps \
     && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN set -ex \
   && for key in \
diff --git a/node_carbon-stretch/Dockerfile b/node_10.0-stretch/Dockerfile
similarity index 98%
copy from node_carbon-stretch/Dockerfile
copy to node_10.0-stretch/Dockerfile
index 3dc7f20..37f0f7e 100644
--- a/node_carbon-stretch/Dockerfile
+++ b/node_10.0-stretch/Dockerfile
@@ -20,7 +20,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 8.11.1
+ENV NODE_VERSION 10.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
@@ -40,7 +40,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt \
   && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN set -ex \
   && for key in \
diff --git a/node_wheezy/Dockerfile b/node_10.0-wheezy/Dockerfile
similarity index 98%
copy from node_wheezy/Dockerfile
copy to node_10.0-wheezy/Dockerfile
index 38527c7..b3c3b13 100644
--- a/node_wheezy/Dockerfile
+++ b/node_10.0-wheezy/Dockerfile
@@ -20,7 +20,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 9.11.1
+ENV NODE_VERSION 10.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
@@ -36,7 +36,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt \
   && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN set -ex \
   && for key in \
diff --git a/node_argon/Dockerfile b/node_10.0/Dockerfile
similarity index 98%
copy from node_argon/Dockerfile
copy to node_10.0/Dockerfile
index c4bceeb..8520834 100644
--- a/node_argon/Dockerfile
+++ b/node_10.0/Dockerfile
@@ -20,7 +20,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 4.9.1
+ENV NODE_VERSION 10.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
@@ -40,7 +40,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt \
   && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN set -ex \
   && for key in \
diff --git a/node_chakracore/Dockerfile b/node_chakracore-10.0/Dockerfile
similarity index 97%
copy from node_chakracore/Dockerfile
copy to node_chakracore-10.0/Dockerfile
index b15e936..c18b08b 100644
--- a/node_chakracore/Dockerfile
+++ b/node_chakracore-10.0/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:jessie
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 8.10.0
+ENV NODE_VERSION 10.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
@@ -17,7 +17,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt \
   && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN set -ex \
   && for key in \
diff --git a/node_chakracore/Dockerfile b/node_chakracore/Dockerfile
index b15e936..b824a26 100644
--- a/node_chakracore/Dockerfile
+++ b/node_chakracore/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:jessie
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 8.10.0
+ENV NODE_VERSION 8.11.1
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
@@ -17,7 +17,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt \
   && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 
-ENV YARN_VERSION 1.5.1
+ENV YARN_VERSION 1.6.0
 
 RUN set -ex \
   && for key in \

@tianon
Copy link
Member

tianon commented Apr 27, 2018

LGTM

Build test of #4289; 804a12c; amd64 (node):

$ bashbrew build node:9.11.1
Using bashbrew/cache:ff40142a0b84ec02a3b1001fc0f36813f7af3aa3680a993ad500b9f8a9ed3374 (node:9.11.1)
Tagging node:9.11.1
Tagging node:9.11
Tagging node:9
Tagging node:latest

$ test/run.sh node:9.11.1
testing node:9.11.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.11.1-alpine
Using bashbrew/cache:b841630c18c65daf7f6ba80c58257f4da7348876304a6f9e2a76f42ecb96ca9d (node:9.11.1-alpine)
Tagging node:9.11.1-alpine
Tagging node:9.11-alpine
Tagging node:9-alpine
Tagging node:alpine

$ test/run.sh node:9.11.1-alpine
testing node:9.11.1-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.11.1-onbuild
Using bashbrew/cache:d8190f41fdb8535c09351a3f58511b73718646b40853694c375d7d212ddba932 (node:9.11.1-onbuild)
Tagging node:9.11.1-onbuild
Tagging node:9.11-onbuild
Tagging node:9-onbuild
Tagging node:onbuild

$ test/run.sh node:9.11.1-onbuild
testing node:9.11.1-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:9.11.1-slim
Using bashbrew/cache:f4105d48bf8f679ad4c03ad41e6d5cfb6bc1108840526e48c2581178baef7b20 (node:9.11.1-slim)
Tagging node:9.11.1-slim
Tagging node:9.11-slim
Tagging node:9-slim
Tagging node:slim

$ test/run.sh node:9.11.1-slim
testing node:9.11.1-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.11.1-stretch
Using bashbrew/cache:892dadbd1ddfb4bfd8a131457971d69194860bdbef46152a7c1f48ea9a43975a (node:9.11.1-stretch)
Tagging node:9.11.1-stretch
Tagging node:9.11-stretch
Tagging node:9-stretch
Tagging node:stretch

$ test/run.sh node:9.11.1-stretch
testing node:9.11.1-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.11.1-wheezy
Using bashbrew/cache:46fd6f39ea51bf4bab29fb332fcf83edec1d1ff90ac6e9cf2f8481c7a35ca3be (node:9.11.1-wheezy)
Tagging node:9.11.1-wheezy
Tagging node:9.11-wheezy
Tagging node:9-wheezy
Tagging node:wheezy

$ test/run.sh node:9.11.1-wheezy
testing node:9.11.1-wheezy
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.11.1
Using bashbrew/cache:7f476e7480b4d0d1bc65db10ade01a32cb1337f2066f2c47b8076358e04b171d (node:8.11.1)
Tagging node:8.11.1
Tagging node:8.11
Tagging node:8
Tagging node:carbon

$ test/run.sh node:8.11.1
testing node:8.11.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.11.1-alpine
Using bashbrew/cache:81dae615802edb7449f73b0c9caf6ca71bcd2c5ce853a5f93cca3fc0ed32f7ea (node:8.11.1-alpine)
Tagging node:8.11.1-alpine
Tagging node:8.11-alpine
Tagging node:8-alpine
Tagging node:carbon-alpine

$ test/run.sh node:8.11.1-alpine
testing node:8.11.1-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.11.1-onbuild
Using bashbrew/cache:40e698d05eae11c527b87f65a8ad41a417f814255c85b5eb865bd700d0b2a5cc (node:8.11.1-onbuild)
Tagging node:8.11.1-onbuild
Tagging node:8.11-onbuild
Tagging node:8-onbuild
Tagging node:carbon-onbuild

$ test/run.sh node:8.11.1-onbuild
testing node:8.11.1-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:8.11.1-slim
Using bashbrew/cache:570d738c36a885c823df6c1091448b96937cb6b2499094b949efa5e7fcbd5e26 (node:8.11.1-slim)
Tagging node:8.11.1-slim
Tagging node:8.11-slim
Tagging node:8-slim
Tagging node:carbon-slim

$ test/run.sh node:8.11.1-slim
testing node:8.11.1-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.11.1-stretch
Using bashbrew/cache:ca8354b96357db4f062f005011eac322feb1f914c65555c584c1e1f9e5e496f3 (node:8.11.1-stretch)
Tagging node:8.11.1-stretch
Tagging node:8.11-stretch
Tagging node:8-stretch
Tagging node:carbon-stretch

$ test/run.sh node:8.11.1-stretch
testing node:8.11.1-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.11.1-wheezy
Using bashbrew/cache:d31f080dc3fdc9fb4ca33ca288ddb879f44fbd44d6a956595d39a71e53d270e7 (node:8.11.1-wheezy)
Tagging node:8.11.1-wheezy
Tagging node:8.11-wheezy
Tagging node:8-wheezy
Tagging node:carbon-wheezy

$ test/run.sh node:8.11.1-wheezy
testing node:8.11.1-wheezy
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.1
Using bashbrew/cache:c5360b236416be919aea853186ae46330028f1982b296d8a706aaf1a1dc80f53 (node:6.14.1)
Tagging node:6.14.1
Tagging node:6.14
Tagging node:6
Tagging node:boron

$ test/run.sh node:6.14.1
testing node:6.14.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.1-alpine
Using bashbrew/cache:9dac3034342055c8a7d270d84e241eaeef22854b954c7ba31760f908554fc12d (node:6.14.1-alpine)
Tagging node:6.14.1-alpine
Tagging node:6.14-alpine
Tagging node:6-alpine
Tagging node:boron-alpine

$ test/run.sh node:6.14.1-alpine
testing node:6.14.1-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.1-onbuild
Using bashbrew/cache:0b22f64acfca6128005b7d82d4554d7a48768f5de69c8906163b460ba2d1f52e (node:6.14.1-onbuild)
Tagging node:6.14.1-onbuild
Tagging node:6.14-onbuild
Tagging node:6-onbuild
Tagging node:boron-onbuild

$ test/run.sh node:6.14.1-onbuild
testing node:6.14.1-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:6.14.1-slim
Using bashbrew/cache:8b9833513e7b871cc9bc12e516b2c7ef16714037e14dc4982b7fffdf008e1123 (node:6.14.1-slim)
Tagging node:6.14.1-slim
Tagging node:6.14-slim
Tagging node:6-slim
Tagging node:boron-slim

$ test/run.sh node:6.14.1-slim
testing node:6.14.1-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.1-stretch
Using bashbrew/cache:4607694e556f251dca496095563523fe8285a3d8fabe77b44c61977bcdbf9459 (node:6.14.1-stretch)
Tagging node:6.14.1-stretch
Tagging node:6.14-stretch
Tagging node:6-stretch
Tagging node:boron-stretch

$ test/run.sh node:6.14.1-stretch
testing node:6.14.1-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.1-wheezy
Using bashbrew/cache:52c9f5a7fc1783201b9b5aa81f7d1cf1483fb4e4e49d5fa5a374089ea7b7ceaf (node:6.14.1-wheezy)
Tagging node:6.14.1-wheezy
Tagging node:6.14-wheezy
Tagging node:6-wheezy
Tagging node:boron-wheezy

$ test/run.sh node:6.14.1-wheezy
testing node:6.14.1-wheezy
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.9.1
Using bashbrew/cache:230f4b020b1dfaad859b9f365d31d8542980e22363c83d64ac885b452c9d7447 (node:4.9.1)
Tagging node:4.9.1
Tagging node:4.9
Tagging node:4
Tagging node:argon

$ test/run.sh node:4.9.1
testing node:4.9.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.9.1-alpine
Using bashbrew/cache:434c3adf1016882fd619a9401c6a5dfde492ed3a1011010656e78c7b92df10a2 (node:4.9.1-alpine)
Tagging node:4.9.1-alpine
Tagging node:4.9-alpine
Tagging node:4-alpine
Tagging node:argon-alpine

$ test/run.sh node:4.9.1-alpine
testing node:4.9.1-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.9.1-onbuild
Using bashbrew/cache:d866dfb52ce6181356131f255752258bcde0f61c93ff6538762a6a1250b19fd1 (node:4.9.1-onbuild)
Tagging node:4.9.1-onbuild
Tagging node:4.9-onbuild
Tagging node:4-onbuild
Tagging node:argon-onbuild

$ test/run.sh node:4.9.1-onbuild
testing node:4.9.1-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:4.9.1-slim
Using bashbrew/cache:a7140fef82ae6d740c5164dd6b16741644d0711436a3fe7b8384c909527e43d7 (node:4.9.1-slim)
Tagging node:4.9.1-slim
Tagging node:4.9-slim
Tagging node:4-slim
Tagging node:argon-slim

$ test/run.sh node:4.9.1-slim
testing node:4.9.1-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.9.1-stretch
Using bashbrew/cache:98a33e2d8a535fc5cc5b6ffa04bbbc30ba9209f1b649dc8945af74bffdeade97 (node:4.9.1-stretch)
Tagging node:4.9.1-stretch
Tagging node:4.9-stretch
Tagging node:4-stretch
Tagging node:argon-stretch

$ test/run.sh node:4.9.1-stretch
testing node:4.9.1-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.9.1-wheezy
Using bashbrew/cache:10bfc5d65f01ac331662de4de6237beb0663f0e6917ade74d7060bbded643190 (node:4.9.1-wheezy)
Tagging node:4.9.1-wheezy
Tagging node:4.9-wheezy
Tagging node:4-wheezy
Tagging node:argon-wheezy

$ test/run.sh node:4.9.1-wheezy
testing node:4.9.1-wheezy
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.0.0
Building bashbrew/cache:fc277db088d6cc22f1aaafb4b7af6a3fe4908ce4f0cbca99f9cb6286c1be278c (node:10.0.0)
Tagging node:10.0.0
Tagging node:10.0

$ test/run.sh node:10.0.0
testing node:10.0.0
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.0.0-alpine
Building bashbrew/cache:6ecd47811188e2566b27eebabb225f76eea93e02c58fc6347c662562fb3f5a52 (node:10.0.0-alpine)
Tagging node:10.0.0-alpine
Tagging node:10.0-alpine

$ test/run.sh node:10.0.0-alpine
testing node:10.0.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.0.0-slim
Building bashbrew/cache:51ed0d5d2af44a0cc70f4701034430a7435332399bd75e310e08d781893b33b6 (node:10.0.0-slim)
Tagging node:10.0.0-slim
Tagging node:10.0-slim

$ test/run.sh node:10.0.0-slim
testing node:10.0.0-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.0.0-stretch
Building bashbrew/cache:c65130905897d0eb2a6dff7286eaeed94cecce66b14f9af79c19c6f31efcc3a8 (node:10.0.0-stretch)
Tagging node:10.0.0-stretch
Tagging node:10.0-stretch

$ test/run.sh node:10.0.0-stretch
testing node:10.0.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.0.0-wheezy
Building bashbrew/cache:38793e4bc4237fceb66803ea6d0c63490b4c183441f0503a4e3ee6c930cc89ec (node:10.0.0-wheezy)
Tagging node:10.0.0-wheezy
Tagging node:10.0-wheezy

$ test/run.sh node:10.0.0-wheezy
testing node:10.0.0-wheezy
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:chakracore-8.11.1
Building bashbrew/cache:7f966197a308ba13e9c296ad7b71545a50c09c0c8f8311615b62af6186b5418b (node:chakracore-8.11.1)
Tagging node:chakracore-8.11.1
Tagging node:chakracore-8.11
Tagging node:chakracore-8
Tagging node:chakracore

$ test/run.sh node:chakracore-8.11.1
testing node:chakracore-8.11.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:chakracore-10.0.0
Building bashbrew/cache:9199dfe4155e33a8963656ac85e4a0c9c66f2de8dd026199f442e60a48ee8e15 (node:chakracore-10.0.0)
Tagging node:chakracore-10.0.0
Tagging node:chakracore-10.0

$ test/run.sh node:chakracore-10.0.0
testing node:chakracore-10.0.0
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed

@tianon tianon merged commit ff1646c into docker-library:master Apr 27, 2018
@PeterDaveHello PeterDaveHello deleted the update-node.js branch April 27, 2018 18:00
@teppeis
Copy link

teppeis commented Apr 28, 2018

@PeterDaveHello
Tag node:10 is missing. Is it intentional?
Only node:10.0 and node:10.0.0 are available.
node:9 or node:8 were beneficial for CI base image in my case.

@SimenB
Copy link
Contributor

SimenB commented Apr 28, 2018

Nope, that's a bug.

Node 9 is still marked as latest as well. My guess is that 10 being double digit confuses our script. I'll take a look.

EDIT: Fix: nodejs/docker-node#705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants