Skip to content

Node: Drop wheezy variant #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Node: Drop wheezy variant #4345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions library/node
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ GitRepo: https://github.com/nodejs/docker-node.git

Tags: 9.11.1, 9.11, 9
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 9023f588717d236a92d91a8483ff0582484c22d1
GitCommit: 773be66016fd1ff4a860529a80af61277f75c7e2
Directory: 9

Tags: 9.11.1-alpine, 9.11-alpine, 9-alpine
Expand All @@ -28,14 +28,9 @@ Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 9023f588717d236a92d91a8483ff0582484c22d1
Directory: 9/stretch

Tags: 9.11.1-wheezy, 9.11-wheezy, 9-wheezy
Architectures: amd64
GitCommit: 9023f588717d236a92d91a8483ff0582484c22d1
Directory: 9/wheezy

Tags: 8.11.1, 8.11, 8, carbon
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: b3ca6573b5c179148b446107386ae96ac6204ad3
GitCommit: 773be66016fd1ff4a860529a80af61277f75c7e2
Directory: 8

Tags: 8.11.1-alpine, 8.11-alpine, 8-alpine, carbon-alpine
Expand All @@ -58,14 +53,9 @@ Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: b3ca6573b5c179148b446107386ae96ac6204ad3
Directory: 8/stretch

Tags: 8.11.1-wheezy, 8.11-wheezy, 8-wheezy, carbon-wheezy
Architectures: amd64
GitCommit: b3ca6573b5c179148b446107386ae96ac6204ad3
Directory: 8/wheezy

Tags: 6.14.2, 6.14, 6, boron
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: bb49c321f761c333ba87b18770121651f0a3004c
GitCommit: 773be66016fd1ff4a860529a80af61277f75c7e2
Directory: 6

Tags: 6.14.2-alpine, 6.14-alpine, 6-alpine, boron-alpine
Expand All @@ -88,14 +78,9 @@ Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: bb49c321f761c333ba87b18770121651f0a3004c
Directory: 6/stretch

Tags: 6.14.2-wheezy, 6.14-wheezy, 6-wheezy, boron-wheezy
Architectures: amd64
GitCommit: bb49c321f761c333ba87b18770121651f0a3004c
Directory: 6/wheezy

Tags: 10.1.0, 10.1, 10, latest
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 2ecc9e8579f519ae3d267b5b497b8c04d6c7040d
GitCommit: 773be66016fd1ff4a860529a80af61277f75c7e2
Directory: 10

Tags: 10.1.0-alpine, 10.1-alpine, 10-alpine, alpine
Expand All @@ -113,10 +98,10 @@ Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 2ecc9e8579f519ae3d267b5b497b8c04d6c7040d
Directory: 10/stretch

Tags: 10.1.0-wheezy, 10.1-wheezy, 10-wheezy, wheezy
Architectures: amd64
GitCommit: 2ecc9e8579f519ae3d267b5b497b8c04d6c7040d
Directory: 10/wheezy
Tags: ., -images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right. I think something went wrong with the manifest generation.

Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit:
Directory: official-images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaurentGoderre This part is odd. I think what's happening is the generate-stackbrew-library.sh is somehow including the locally checked out official-images repo and because that repo has a Docekrfile, it's including it in the manifest generation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOOOH! you're right!!!....wonder if I should try ignoring that folder or in Travis, clone in the parent directory. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I think maybe it's better to clone the directory somewhere else if possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I don't think we would have caught this without having the actual PR happen. Nice to see that part working tho!


Tags: chakracore-8.11.1, chakracore-8.11, chakracore-8
Architectures: amd64
Expand All @@ -127,4 +112,3 @@ Tags: chakracore-10.0.0, chakracore-10.0, chakracore-10, chakracore
Architectures: amd64
GitCommit: f713f15abe3ff05635326ba9716b7755c9d5f1aa
Directory: chakracore/10