fix: install.sh in dumb TERM #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Can you run the pre-commit? @FabioAntunes |
When $TERM is dumb the number of colours returned is -1 we end up with no values set for the colours.
auto-merge was automatically disabled
April 17, 2024 13:20
Head branch was pushed to by a user without write access
|
I raised the PR through the GitHub ui, noticed that the issue was white
spaces I have pushed some changes to fix those white spaces issue. if
that’s not enough to make the pipeline happy I will run the pre-commit
later today.
…On Wed, 17 Apr 2024 at 11:36, dark0dave ***@***.***> wrote:
Can you run the pre-commit? @FabioAntunes
<https://github.com/FabioAntunes>
—
Reply to this email directly, view it on GitHub
<#587 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATNIINPZNDRQOMVUBTGRLLY5ZGEHAVCNFSM6AAAAABGJXD72GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQHE2TEOBSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks! |
dark0dave
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When $TERM is dumb the number of colours returned is -1 we end up with no values set for the colours.
To test this:
You should get an error regarding parameter expansion:
This PR fixes the issue by initialising the variables no matter what.