feat: add support for apple authentication #3
+301
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupansh-sekar-yral
force-pushed
the
main
branch
from
7cc9f29 to
9cbb4fd
Compare
Comment on lines
+162
to
+177
| let cur_exp = self.cache_expiry_epoch_secs.load(Ordering::Acquire); | ||
| if cur_epoch < cur_exp { | ||
| return self.cache.read().unwrap().clone(); | ||
| } | ||
|
|
||
| let mut cache = self.cache.write().unwrap(); | ||
| let (client_secret, expiry_epoch) = self.keygen.generate_client_secret(); | ||
|
|
||
| let new_client = cache | ||
| .as_ref() | ||
| .clone() | ||
| .set_client_secret(client_secret.clone()); | ||
| let new_client = Arc::new(new_client); | ||
| *cache = new_client.clone(); | ||
| self.cache_expiry_epoch_secs | ||
| .store(expiry_epoch, Ordering::Release); |
There was a problem hiding this comment.
One question - Do the Acquire/Release act as mutex here and is .load(Ordering::Acquire) a blocking operation for threads ? else I think after expiry we will regenerate secrets multiple times.
Also is that a concern for us if that happens.
nomicon is confusing - https://doc.rust-lang.org/nomicon/atomics.html#acquire-release
will prolly go through https://marabos.nl/atomics/memory-ordering.html#release-and-acquire-ordering and https://youtu.be/rMGWeSjctlY?list=PLqbS7AVVErFiWDOAVrPt7aYmnuuOLYvOa over the weekend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements dolr-ai/product-roadmap#136