[typescript-resolvers] Refactor to remove NameNode override and simplify federation functions

[eddeee888]

Description

To prepare for next major version, we want to fix a few long-standing type cast issues for typescript-resolvers plugin and federation support:

• Previously ,NameNode was implemented to change how a node name can be accessed. Instead of node.name.value, it just becomes node.name. However, the type of this node (from graphql package) does not know that this is changed at runtime, so we always need to type case as any as string or as unknown as string to satisfy TypeScript. This results in confusion for contributors, and normally requires runtime debug to understand/correctly use the right value.
  • This PR removes NameNode function to avoid typecasts later
• Some functions in federation.ts take both AST nodes and types. This adds more complexity as there are more code paths to think about.
  • This PR simplifies and make it more consistent by requiring functions in federation support to use AST nodes.

Type of change

• Refactor

How Has This Been Tested?

• Unit test

[changeset-bot]

⚠️ No Changeset found

Latest commit: c85c666

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR