[Mono.Android] pass in Context at startup
#9776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `Android.App.Application.Context` currently reads the `mono.MonoPackageManager.Context` field, which is set on startup by a `ContentProvider`. `mono.MonoPackageManager` does not exist in NativeAOT (or CoreCLR), so let's approach this differently. Each `ContentProvider` can pass in the context to `JNIEnvInit` on startup, then the first call to `Android.App.Application.Context` does not have to read a field any longer as we already have the handle in managed code.
jonathanpeppers
commented
Feb 10, 2025
|
APK tests crash on launch: |
|
Going to close this in favor of: I think the other PR is just simpler and changes no semantics / ordering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Android.App.Application.Contextcurrently reads themono.MonoPackageManager.Contextfield, which is set on startup by aContentProvider.mono.MonoPackageManagerdoes not exist in NativeAOT (or CoreCLR), so let's approach this differently.Each
ContentProvidercan pass in the context toJNIEnvIniton startup, then the first call toAndroid.App.Application.Contextdoes not have to read a field any longer as we already have the handle in managed code.