-
Notifications
You must be signed in to change notification settings - Fork 551
[Xamarin.Android.Build.Tasks] temporarily support .NET 8 in .NET 10 #9777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android-libraries#1084 (comment) Context: https://aka.ms/maui-support-policy dotnet/android-libraries needs to build with: <TargetFrameworks>net8.0-android;net10.0-android</TargetFrameworks> Typically each .NET release, we only support N-1 `$(TargetFrameworks)` and import `Eol.targets` to emit an error message on older versions. We can make some .NET workload changes to support .NET 8 in a .NET 10 SDK until .NET 8 goes out of support in May. I also updated some MSBuild tests to ensure .NET 8 projects build & run.
dellis1972
approved these changes
Feb 11, 2025
pjcollins
approved these changes
Feb 11, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Feb 12, 2025
…orkload Context: #9777 The problem with #9777, is it increases our install size by something like ~700MB with the following packs: * Microsoft.Android.Sdk.[platform] x 1 (current platform) * Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.[RID] x 4 RIDs * Microsoft.NETCore.App.Runtime.Mono.[RID] x 4 RIDs Some of .NET MAUI's CI machines are extremely tight on disk space, and we promptly filled the disk! Let's move these packs to a new `android-net8` workload, which can be installed separately. dotnet/android-libraries could simply install: dotnet workload install android-net8 Which would provision both `android` and `android-net8` workloads.
grendello
added a commit
that referenced
this pull request
Feb 12, 2025
* main: Bump to dotnet/java-interop@57f7bc84 (#9724) [XABT] Fix Xamarin.Android.Build.Tasks.sln (#9782) [java-runtime, Mono.Android] Use `ApplicationRegistration.Context` (#9779) [Xamarin.Android.Build.Tasks] temporarily support .NET 8 in .NET 10 (#9777) Bump to dotnet/sdk@c0f88f2416 10.0.100-preview.2.25108.4 (#9775) [docs] update dotnetbuilds domain (#9772)
jonathanpeppers
added a commit
that referenced
this pull request
Feb 14, 2025
…orkload (#9785) Context: #9777 The problem with #9777, is it increases our install size by something like ~700MB with the following packs: * Microsoft.Android.Sdk.[platform] x 1 (current platform) * Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.[RID] x 4 RIDs * Microsoft.NETCore.App.Runtime.Mono.[RID] x 4 RIDs Some of .NET MAUI's CI machines are extremely tight on disk space, and we promptly filled the disk! Let's move these packs to a new `android-net8` workload, which can be installed separately. dotnet/android-libraries could simply install: dotnet workload install android-net8 Which would provision both `android` and `android-net8` workloads.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android-libraries#1084 (comment)
Context: https://aka.ms/maui-support-policy
dotnet/android-libraries needs to build with:
Typically each .NET release, we only support N-1
$(TargetFrameworks)
and importEol.targets
to emit an error message on older versions.We can make some .NET workload changes to support .NET 8 in a .NET 10 SDK until .NET 8 goes out of support in May.
I also updated some MSBuild tests to ensure .NET 8 projects build & run.