SetHandler improvements #1729
Merged
SetHandler improvements #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
May 5, 2022
| @@ -44,7 +44,7 @@ public async Task Sets_output_mode_to_Ansi_when_specified_by_output_directive(Ou | |||
| OutputMode detectedOutputMode = OutputMode.Auto; | |||
|
|
|||
| var command = new Command("hello"); | |||
| command.SetHandler((InvocationContext ctx) => | |||
| command.SetHandler(ctx => | |||
There was a problem hiding this comment.
it's really nice for the simple handlers to be naturally-typed here (and in the other 1000 callsites in this PR)
There was a problem hiding this comment.
Agreed. Settling on InvocationContext for the case where we do this (i.e. removing support for ParseResult, etc. as parameters) reduces a lot of DI-ish complexity in these handlers. If we pull this thread hard enough, the need for the service provider might disappear.
baronfel
reviewed
May 5, 2022
Keboo
reviewed
May 5, 2022
| { | ||
| var valueSource = ValueDescriptorDefaultValueSource.Instance; | ||
|
|
||
| valueSource.TryGetValue(valueDescriptor, context, out var value); |
There was a problem hiding this comment.
nit: I dislike var here as it is not clear what the type of value is.
| { | ||
| var valueSource = ValueDescriptorDefaultValueSource.Instance; | ||
|
|
||
| valueSource.TryGetValue(valueDescriptor, context, out var value); |
There was a problem hiding this comment.
Should we care about the case where TryGetValue returns false? Should there be something line BoundValue.None to return in that case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes attempt to improve the clarity of the
SetHandlermethods by removing theparamsparameters and replacing them with a number ofIValueDescriptor<T>parameters matching the number of generic type arguments.Since DI-like behaviors are fairly non-obvious, I'll likely also experiment here with removing the internal service provider and see if
BinderBase<T>can fulfill its role.