Allow Suggestions to be replaced #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I want to discuss this in an issue to make sure we have all the cases considered.
Please use #956 for general discussion of the problem.
|
Please add some tests. One test that would really help clarify the scenario is the one we discussed where you're parsing to an enum allowing a number of "alias" values. |
sure thing I was going to wait to see if there was any desire to take this API first |
|
updated with tests |
|
all I need really is the ability to disable |
jonsequitur
reviewed
Jun 30, 2020
jonsequitur
reviewed
Jun 30, 2020
jmarolf
force-pushed
the
feature/allow-suggestions-to-be-replaced
branch
from
80e595a to
271efbe
Compare
jmarolf
commented
Jun 30, 2020
jmarolf
force-pushed
the
feature/allow-suggestions-to-be-replaced
branch
from
271efbe to
1be787b
Compare
jonsequitur
reviewed
Jul 1, 2020
jonsequitur
reviewed
Jul 1, 2020
Keboo
approved these changes
Jul 1, 2020
jonsequitur
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite to enable dotnet/format#711 to be merged