Skip to content

Don't compare boolean with false #45934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Don't compare boolean with false #45934

merged 1 commit into from
Apr 28, 2025

Conversation

gfoidl
Copy link
Member

@gfoidl gfoidl commented Apr 28, 2025

Alternatively pattern matching is false could be used.
Just to keep George Bool happy 😉


Internal previews

📄 File 🔗 Preview link
docs/csharp/whats-new/csharp-14.md What's new in C# 14

Alternatively pattern matching `is false` could be used.
@gfoidl gfoidl requested review from BillWagner and a team as code owners April 28, 2025 08:23
@dotnetrepoman dotnetrepoman bot added this to the April 2025 milestone Apr 28, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-csharp/svc whats-new/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels Apr 28, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@BillWagner BillWagner merged commit 1d9a684 into dotnet:main Apr 28, 2025
13 checks passed
@gfoidl gfoidl deleted the patch-3 branch April 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc whats-new/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants